clang Use llvm-ar linker when LTO flag is set.
#1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is required for some clang features like `-flto`. Still defaults to `ar` if the `LinkTimeOptimization` flag is not set.
|
Please fill in the template, it's there for a reason. |
please reopen |
|
It seems a bit inconsistent that the tool will be different depending on if LTO is enabled or not. Is there any reason not to just always use |
|
|
Makes sense, thanks. |
samsinsane
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the static linker from
artollvm-arwhen theclangtoolset is used and theLinkTimeOptimizationflag is set.Although many times
GNU arwill also work, for some clang features like-flto(link-time optimisation, I only came across this one but could be more)llvm-aris needed.How does this PR change Premake's behavior?
It should not break or change build-file output for existing projects (that may not have
llvm-arinstalled) sincellvm-aris only conditionally used and still defaults toar.Anything else we should know?
Before this change, it was not possible to use the
LinkTimeOptimizationflag with the clang toolset unless using the "AR=llvm-ar" environment variable.Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!